Opened 6 years ago
Closed 6 years ago
#1146 closed task (fixed)
Need to add Release notes for 4.2
Reported by: | butler | Owned by: | butler |
---|---|---|---|
Priority: | blocker | Milestone: | SasView 4.2.0 |
Component: | SasView | Keywords: | |
Cc: | Work Package: | SasView Bug Fixing |
Change History (10)
comment:1 Changed 6 years ago by butler
- Owner set to smk78
- Status changed from new to assigned
comment:2 Changed 6 years ago by smk78
comment:3 Changed 6 years ago by smk78
Have updated \sasview\installers\README-next-release.txt with notes for 4.2.0.
comment:4 Changed 6 years ago by smk78
To do:
- In \sasview\installers\ rename README.txt to README-old-release.txt and README-next-release.txt to README.txt.
- Go to https://github.com/SasView/sasview/releases/ and create a new release. Paste contents of release notes sent to @butler into it.
NB: Address the questions (search on ???) and edit the Known Issues section in both before making live.
comment:5 Changed 6 years ago by smk78
- Owner changed from smk78 to butler
comment:6 Changed 6 years ago by smk78
comment:7 Changed 6 years ago by smk78
I have just pushed an update to the Release Notes upto & including ticket 1184. Note, Changes section and bullet list of tickets were updated. In my opinion, now ready for release.
comment:8 Changed 6 years ago by butler
Just taken a quick look — two points:
- I re-closed ticket 1148 and generated an new ticket for the enhancement you noted. Ticket 1148 was a bug that I only discovered because of a user complaining about being confused … and when I checked they were right: the documentation was wrong (though you could argue that it described the behavior that we may actually want but that is not the current behavior) - so perhaps the correct way to say it is that the documentation was at odds with the code This I think is quite different from the general improvement that all models could use. Because it was an actual bug I think it should be added back to the list of fixed bugs
- We should probably not claim as FIXED tickets which were closed as won't fix such as #980, #1103, #1134 (actually listed as invalid) or #1184
- #1012 is "ESS GUI not updating after fitting" clearly should be against 5.0 .. the fix is not part of 4.2. I have moved the ticket to 5.0
- Not sure it is helpful to list all the admin tasks such as #1133 or #1146, or even for that matter do we want to list things like #1174 or #1133?
Finally I'm not sure we should promise in the release notes that we will fix the marketplace … just in case we are slow … and actually looking at some of them tonight am realizing that maybe we should NOT in fact be changing files people upload as they may be using that as a repo of the code they used in SasView? for their paper. Instead we might make a duplicate that works with the new API?
comment:9 Changed 6 years ago by smk78
Replying to @butler in #comment:8
- Fine by me!
- Ok. Removed.
- Agreed. Oddly I found the ticket hadn't been moved to 5.0 so I just did so.
- Ok. Removed.
I didn't put that note about updating the marketplace in, it was already in the release notes for 4.1.2!!! But I have now removed it.
Have just pushed the updated RELEASE.txt back to master.
comment:10 Changed 6 years ago by smk78
- Resolution set to fixed
- Status changed from assigned to closed
Just done one last update adding in #1188. Should be ready for release now.
Closing this ticket.
Mostly complete release notes document sent to @butler to finalise.
Will leave this ticket as a blocker for now so no one forgets to upload them!