Opened 3 years ago

Last modified 3 years ago

#1147 new enhancement

Organise parameter table by model component

Reported by: tcbennun Owned by: tcbennun
Priority: major Milestone: SasView 5.0.0
Component: SasView Keywords:
Cc: Work Package: SasView GUI Enhancements


As discussed in comments here:

From JIRA:

SASVIEW-966: Organise parameter table by model component
Torin Cooper-Bennun, 24 July 2018 09:46

In order to reduce confusion of where parameters are coming from in P(Q)S(Q), sum/multi, or more complicated mixture models, the model parameter table could include sub-headings to separate the parameters by model component.

I've mocked it up on the ESS_GUI_beta_approx branch in the simple case of P(Q)S(Q);

This currently uses non-checkable, non-selectable, bold-face rows as headings. I'm a bit concerned that using top-level rows as headings may break some other manipulation of the item model, though.

Piotr Rozyczko, 24 July 2018 10:17

This looks good!

As for potential fallout - (hopefully) all operations on the naked model are done through special methods in GuiUtilities?, so location of potential fixes is well defined. Also, as a general rule I tend to iterate over model items testing if the item is checkable - only then I look for its children etc.

The "Polydispersity" row acts almost exactly like your multi-column description rows.

Attachments (1)

param_subheadings.png (16.5 KB) - added by tcbennun 3 years ago.
example of param sub-headings in the GUI

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by tcbennun

example of param sub-headings in the GUI

comment:1 Changed 3 years ago by tcbennun

The parameters 'scale' and 'background' are not part of any single model component. Is it clear to the user what is meant by them if they stand heading-less at the top of the table?

comment:2 Changed 3 years ago by piotr

This has been implemented by Torin some time ago and is now pretty well tested in 5.0

Note: See TracTickets for help on using tickets.