Opened 7 years ago

Closed 7 years ago

#889 closed defect (fixed)

Refactor dataloader error handling infrastructure

Reported by: krzywon Owned by: krzywon
Priority: critical Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Framework Enhancements

Description

Error handling in dataloader does not properly catch errors. When a reader listed as the default for a file throws an error, that error is discarded and then the file is sent to the ASCII and cansas XML readers. The errors from the cansas reader are then sent back up the line, and the original errors are lost.

I outlined a way to handle this in a (now closed) pull request and can implement this for 4.2.0.
​https://github.com/SasView/sasview/pull/44

Change History (3)

comment:1 Changed 7 years ago by krzywon

In 7f75a3fc9b6c1be1b8f3ee54e1879b3fd8f5e4d6/sasview:

More explicit error messages when file loading fails. see #889

comment:2 Changed 7 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to accepted

comment:3 Changed 7 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In f001bc9e4b9d1ac0d4712117442f0c949334dbc4/sasview:

Merge pull request #95 from lewisodriscoll/ticket-876

Refactor File Loaders - fixes #889 #950 #849 #876 #922 #983 #970

Note: See TracTickets for help on using tickets.