Opened 7 years ago

Closed 7 years ago

#970 closed defect (fixed)

ASCII loader doesn't handle ISIS 2D ASCII

Reported by: smk78 Owned by: lewis
Priority: critical Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Testing 4.1.1 Build 180 on w10 (but this issue also exists in 3.1.2 and I assume all subsequent versions).

In testing the forthcoming Mantid release I did a 2D reduction and output the result as (our) ISIS/RKH 2D .TXT, as NIST 2D .DAT, and as NXcanSAS .H5.

All three load in SasView, but only the .DAT and .H5 plot correctly. The .TXT seems to get interpreted as 1D.

This is a long-standing issue that we ought to do something about.

Example files attached.

Attachments (3)

shirin100254_merged_2D.txt (242.3 KB) - added by smk78 7 years ago.
ISIS 2D ASCII format file
shirin100254_merged_2D.dat (343.0 KB) - added by smk78 7 years ago.
NIST 2D ASCII format file
shirin100254_merged_2D.h5 (280.3 KB) - added by smk78 7 years ago.
NXcanSAS 2D HDF format file

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by smk78

ISIS 2D ASCII format file

Changed 7 years ago by smk78

NIST 2D ASCII format file

Changed 7 years ago by smk78

NXcanSAS 2D HDF format file

comment:1 Changed 7 years ago by smk78

  • Owner set to lewis
  • Status changed from new to assigned

As NXcanSAS will become our default 2D format, propose we solve this ticket by trapping the bad load with an elegant message, but add the ISIS 2D format to the File Converter tool (to output as NXcanSAS).

At the same time, propose we also add the NIST 2D format to the File Converter so that it can be deprecated in the main loader in a future release (butler, pers. comm.)

comment:2 Changed 7 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In f001bc9e4b9d1ac0d4712117442f0c949334dbc4/sasview:

Merge pull request #95 from lewisodriscoll/ticket-876

Refactor File Loaders - fixes #889 #950 #849 #876 #922 #983 #970

Note: See TracTickets for help on using tickets.