Opened 3 years ago

Last modified 7 months ago

#888 new defect

Support numpy v1.12.0+ - Array indices must be integers

Reported by: krzywon Owned by:
Priority: major Milestone: SasView 4.3.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

As of numpy v1.12.0, all array indices are required to be integers, not floating point. This is causing issues in unit tests in the Igor reader. As of now, Jenkins uses an older version of numpy, but going forward, we should try to use the latest versions of every package to minimize the number of specific packages needed.

Pull request where this was found:
https://github.com/SasView/sasview/pull/47
Travis CI build log where the errors are happening:
https://travis-ci.org/SasView/sasview/builds/212831209
Numpy changelog outlining this new feature:
https://github.com/numpy/numpy/blob/master/doc/release/1.12.0-notes.rst

Change History (5)

comment:1 Changed 3 years ago by krzywon

The Igor Reader is confirmed to not use integer indices in numpy arrays, but there may be other places in sasview (and sasmodels) that have not been found yet.

comment:2 Changed 2 years ago by krzywon

The following files have been fixed so far:

/sas/sascalc/dataloader/readers/IgorReader.py
/sas/sascalc/calculator/slit_length_calculator.py

A final run through is still required.

comment:3 Changed 2 years ago by krzywon

In b1f20d17802efab479556ccd4fab9ef91f08b7bb/sasview:

Make invariant calculator numpy 1.12+ compatible. refs #888

comment:4 Changed 2 years ago by butler

  • Milestone changed from SasView 4.2.0 to SasView 4.3.0

comment:5 Changed 7 months ago by GitHub <noreply@…>

In 8c9e65cd9988f16ea56b788b64869dfe1a16334c/sasview:

py37 support for sascalc. Refs #888 an #1233.

Note: See TracTickets for help on using tickets.