Opened 7 years ago
Closed 7 years ago
#890 closed defect (fixed)
use new orientation definition for asymmetric shapes
Reported by: | pkienzle | Owned by: | pkienzle |
---|---|---|---|
Priority: | blocker | Milestone: | SasView 4.2.0 |
Component: | sasmodels | Keywords: | |
Cc: | Work Package: | SasModels Redesign |
Description
Change History (12)
comment:1 Changed 7 years ago by pkienzle
- Owner set to pkienzle
- Status changed from new to assigned
comment:2 Changed 7 years ago by pkienzle
- Milestone changed from SasView 4.1.0 to SasView 4.2.0
comment:3 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:4 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:5 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:6 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:7 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:8 Changed 7 years ago by Paul Kienzle <pkienzle@…>
comment:9 Changed 7 years ago by richardh
triaxial ellipsoid and the parrallelepiped models still need modifications to their effective radius calculation.
triaxial_ellipsoid no longer asks users to keep A<B<C, For ER() need sort so that a≤b≤c; then if b is closer to a than to c, then we are prolate, a,b are equatorial axes and c is polar; else for oblate, a is polar and b,c are equatorial. Note this then uses ER() for ellipsoid, which has different calcs for oblate & prolate.
The paralleliped ER() uses that for cylinder, which seems not to have different version for rod and disk. But likewise we could sort the axes for ER() which would possibly remove the a<b<c requirement on theses models, but this needs testing!
Summary of what Paul K has already done in this ticket, apart from sorting the 2d I(Q) calculation:
major refactoring of calc of I(Q) in - core_shell_bicelle, ellipsoid
redone equations in docu in - ellipsoid, triaxial_ellipsoid
comment:10 Changed 7 years ago by richardh
comment:11 Changed 7 years ago by richardh
There are some notes in elliptical_cylinder about how many bins to use for orientational averages, these should be reviewed when we have he new integration scheme.
comment:12 Changed 7 years ago by pkienzle
- Resolution set to fixed
- Status changed from assigned to closed
In b00a646c6ab83c01056acef9b46d1e392433af0b/sasmodels: