Opened 4 years ago

Closed 4 years ago

#862 closed defect (fixed)

Behavior changed when selecting a model from drop down

Reported by: butler Owned by: krzywon
Priority: major Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

As stated in the extensive documentation rewrite made by Steve King at code camp V, the behavior in previous versions when selecting a model from a fit page (in the absence of data) caused a graph to pop up with the model using the default parameters. When a parameter is changed followed by a return the plot updates.

Currently no plot is generated when a new model is selected, though the GUI shows the parameters and their default values. The user has to hit compute (or place the cursor in one of the parameter boxes then hit enter) to force a plot.

Was this a deliberate change in behavior??? I don't think it should be. if however it is we need to change the documentation (fitting_help.rst). Otherwise we should fix so that the old behavior is recovered.

Change History (8)

comment:1 Changed 4 years ago by smk78

SasView-4.1-Win7Test-Build165 (that Wojtek asked me to download last week to check corfunc was back in the distribution) works as SasView always has…

What platform were you testing Paul?

comment:2 Changed 4 years ago by ajj

Build 587ce8 shows this problem (Feb 27th).

Build 2510b9 does not (Feb 21st)

comment:3 Changed 4 years ago by ajj

This bug was introduced in either commit cb05bfd or 925258.

Suspect that it was the merge of pull request 36 (cb05bfd) and the call to self.onSmear() added in line 2018 of fitpage.py

Last edited 4 years ago by ajj (previous) (diff)

comment:4 Changed 4 years ago by wojciech

I experienced the same on OSX 10.11.
It is only for the first model selected that one needs to press Compute button. If I then select another model everything seems to be back to normal.

comment:5 Changed 4 years ago by richardh

In version I have just built from master on my windows pc.

When I have P(Q).S(Q) e.g. sphere x MSA, then pressing "enter/return" after changing a parameter value gets a fresh calculation on the plot, BUT pressing "compute" after changing a parameter value does not. Worked as expected with just P(Q). Perhaps this needs its own ticket?

comment:6 Changed 4 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to assigned

This is probably something to do with what I changed for #844. I will look into this.

comment:7 Changed 4 years ago by krzywon

In fdaf2b1cc4c09c73bba16893450149c98df1bb5c/sasview:

Force a redraw of the model every time a new one is selected. #862

comment:8 Changed 4 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 951701cabbe7a4920ecd104375f77d06724f08b6/sasview:

Merge pull request #37 from SasView?/ticket-844-part2

Smearing set properly when sent to fitting and fit plotted when model selected. Closes #844, #862.

Note: See TracTickets for help on using tickets.