Opened 2 years ago

Closed 2 years ago

#844 closed defect (fixed)

smearing state seems broken

Reported by: richardh Owned by: krzywon
Priority: blocker Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

On start up of 4.1, "use dQ data" button is selected but greyed out, and "The dQ data is being used for smearing … " appears underneath the buttons. "None" ought to be selected as default.

On sending to Fitting a data set that does not have any dQ values, the above defaults do not change.

When I did send some data with dQ values, they were not recognised.

Change History (10)

comment:1 Changed 2 years ago by butler

  • Priority changed from critical to blocker

comment:2 Changed 2 years ago by smk78

  • Owner changed from butler to wojciech
  • Status changed from new to assigned

comment:3 Changed 2 years ago by krzywon

In 03137f105ce4c5ff8a89fcd2d26141830af2dc91/sasview:

Default dQ is now None. dQ from data is selected automatically if dta has dQ smearing. #844

comment:4 Changed 2 years ago by krzywon

In 3d5521989589282c6dd46e1dd009a43a8001a35e/sasview:

Check for slit smearing as well as pinhole, more pythonic truth checking and moved smearing to after dI is set. #844

comment:5 Changed 2 years ago by krzywon

  • Owner changed from wojciech to krzywon

comment:6 Changed 2 years ago by krzywon

  • Resolution set to fixed
  • Status changed from assigned to closed

This is now fixed and in master.

comment:7 Changed 2 years ago by krzywon

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change throws errors when loading save states due to no model being set before applying qsmearing to the data and model. Also, the dxl and dxw values are not set in the gui properly.

comment:8 Changed 2 years ago by krzywon

In c1c9929d6b02699660b0af8a643376612943deb8/sasview:

Set smearer model before entering the smearing calculation. #844

comment:9 Changed 2 years ago by krzywon

In 2d568f649389db3d59ceb4e0e7c433010da67d64/sasview:

Change which method is called to only update params, but not calculate smearing. #844

comment:10 Changed 2 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from reopened to closed

In 951701cabbe7a4920ecd104375f77d06724f08b6/sasview:

Merge pull request #37 from SasView?/ticket-844-part2

Smearing set properly when sent to fitting and fit plotted when model selected. Closes #844, #862.

Note: See TracTickets for help on using tickets.