Opened 2 years ago

Closed 2 years ago

#863 closed defect (duplicate)

Load Plugin error

Reported by: butler Owned by: pkienzle
Priority: blocker Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description (last modified by butler)

Load Plugin is used to force an update of plugin models that may have changed but somehow not triggered an auto update. This works fine if the category at the time is not Plugin Model. However if it is "Plugin Model" and a plugin is selected on the fit page, load will clear the model dropdown box, but does not clear the rest of the model GUI stuff on the fit page. If the user then tries to change a parameter and run the model (e.g. by hitting return) throws an error. If the user then goes to the model selection drop down and reselects the model all is well again.

2017-02-26 11:30:47 : Traceback (most recent call last):
File "C:\Users\Paul\git\sasview_new\src\sas\sascalc\data_util\calcthread.py", line 268, in _run
    self.compute(*args, **kwargs)
AttributeError: 'NoneType' object has no attribute 'pow'

2017-02-26 11:30:47 : Traceback (most recent call last):
File "C:\Users\Paul\git\sasview_new\src\sas\sascalc\data_util\calcthread.py", line 268, in _run
    self.compute(*args, **kwargs)
AttributeError: 'NoneType' object has no attribute 'pow'

Interesting factoid: there are 4 types of models: new style (e.g. copied from the built in), created using simple model editor (essentially new style), old style plugins, and the sum/multiply models which remain a mix of styles. This last type in fact seems to be quite happy even when the drop down is cleared - i.e. it does not throw the error and in fact continues to work fine when parameters are changed as if it is loaded at some deeper level? maybe deep copy issue?

Possible solutions:

  1. Rather than reset the selected model of Plugin Model, the code could reload whatever model had been selected and keep that model in the dropdown.
  2. Finish the reset operation. Basically this is behaving similarly to changing category which clears the model selection box AND clears all the model GUI elements on the page. So just finish the job and clear out all those elements.


Change History (2)

comment:1 Changed 2 years ago by butler

  • Description modified (diff)

comment:2 Changed 2 years ago by butler

  • Resolution set to duplicate
  • Status changed from new to closed

This was a first observation of a deeper issue documented in #865. Have moved this information there and thus closing this as a duplicate.

Note: See TracTickets for help on using tickets.