Opened 3 years ago

Closed 3 weeks ago

#470 closed defect (worksforme)

Rearranging tabs isn't working perfectly

Reported by: mathieu Owned by: butler
Priority: major Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

If you have multiple tabs in the fit panel and rearrange them, there is no way to bring them back in the same sub-window.

Change History (7)

comment:1 Changed 3 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

comment:2 Changed 14 months ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 5.0.0

comment:3 Changed 3 months ago by tim

  • Owner set to butler
  • Status changed from new to assigned

Is this still relevant in the ESS_GUI branch?

It would appear not to be…

comment:4 Changed 3 months ago by butler

It is actually very hard to do but possible as I recall. However the point you make: it is not relevant to ESS GUI is appropriate and the question is whether it is worth expending the limited resources on fixing this Wx issue or just wait till QT GUI is out (5.0). I think the fact that this ticket was placed into the ESS GUI means we opted for the latter. Question: Does the ESS GUI even allow rearrangement?

comment:5 Changed 4 weeks ago by piotr

Yes, tabs can be rearranged freely in the fitting widget in 5.0. However, what is being meant by "bringing them back in the same subwindow"? Automatic re-arranging to the original order? If so, how is the original order defined?

comment:6 Changed 4 weeks ago by butler

I think we can probably close this. Just checked in 4.2 in order to explain better and see that it actually seems to works well now in 4.2. I'm also not sure anybody uses the feature.

So in Wx you can pull a tab out into a new "window" within the fit panel which will then snap to the right, top or bottom depending on which edge you drop it on. You can then have both tabs visible at once (or more). The problem used to be that if you wanted to move the tabs back into one window as tabs instead of windows, it was nearly impossible to do so.

playing now with 5.0 I don't think that is possible there. Question is whether that is a necessary feature to carry over. Given how much it has been used I would argue maybe not. I guess the one place it would have been useful is to look at fits side by side but I think we already a real estate poor so not sure it was ever going to work that way? Should we decide at next call whether to remove this feature as a requirement?

comment:7 Changed 3 weeks ago by butler

  • Milestone changed from SasView 5.0.0 to SasView 4.2.0
  • Resolution set to worksforme
  • Status changed from assigned to closed

By general agreement on the Nov 27, 2018 conf call, this is no longer a necessary feature desired for 5.0 and beyond and trying to force that would be a lot of work anyway. Thus we will move this back to 4.2 and close

Note: See TracTickets for help on using tickets.