Opened 3 years ago

Last modified 3 months ago

#475 new enhancement

Add volume fraction explicitly in all relevant models

Reported by: smk78 Owned by:
Priority: major Milestone: SasView Next Release +1
Component: SasView Keywords:
Cc: Work Package: Beta Approximation Project

Description (last modified by butler)

11 November 2015 23:19
Subject: Re: [SasView] Ticket #472: reparameterize Teubner-Strey

Wonder if what we want to do …eventually - don't think we want to muddy waters right this minute (could be for code camp?) but maybe we want to add phi explicitly in all the models where it comes in. This might help reduce confusion in that scale will then always be one except to fix normalizaition problems (no abs scale or the phi and slds chosen and fixed by user are wrong). It would add a parameter to the GUI but at least it would then be consistent across all models?

Paul

Attachments (2)

param_subheadings.png (16.5 KB) - added by tcbennun 5 months ago.
image001.png.png (19.5 KB) - added by tcbennun 5 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by butler

  • Milestone changed from WishList to SasView 4.0.0
  • Work Package changed from SasView Fitting Redesign to SasModels Redesign

comment:2 Changed 2 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

comment:3 Changed 2 years ago by butler

  • Description modified (diff)

Moving back to 4.0 as part of ticket #643 admonition to finalize parameter and model names so as to remain compatible in the future. Does this come under that heading?

comment:4 Changed 5 months ago by butler

  • Work Package changed from SasModels Redesign to Beta Approximation Project

I think(?) that we have been talking around this issue during discussion of the beta approximation. The pros and cons were left mostly at the con level so far: having yet another parameter on the screen to deal with which is completely correlated to the scale factor seemed to override the elegance of separating an arbitrary scale factor (data not on absolute scale) from the volume fraction and thus making it explicit for the user what "scale" is (we get lots of questions on that despite trying to put that in the documentation).

Now that we are focussing on composite models of various sorts it may be time to revisit this question? At any rate will move this to the beta approximation work package for now.

comment:5 Changed 5 months ago by richardh

The default P(Q)S(Q) is one case where volfraction (from S(Q) ) is included in the absolute intensity, and we have a separate "scale".   The same P(Q)S(Q) generated as a plugin model by sum/multi has a single "scale".

Perhaps we should call the parameter "scale_volfraction" when there is only one of them, and "scale" and "volfraction" when there are both????

comment:6 Changed 5 months ago by smk78

I would suggest it would be better to re-label them the other way: keep scale as is, but change volfraction to SQ_volfraction, or similar. It would be less disturbance to the docs…

comment:7 Changed 5 months ago by richardh

Yes, i had thought likewise, but we need to make it clear how the absolute intensity is derived. Torin already has an idea to insert sub-headings with the actual model names into the parameter list in 5.0, so it will be more obvious which parameters relate to which P(Q) and/or S(Q) without having to modify their names, and with the insertion of brackets around the sub-headings, even the order of more complex calculations.

Changed 5 months ago by tcbennun

Changed 5 months ago by tcbennun

comment:8 Changed 3 months ago by pkienzle

Need to be careful with F(q) and calculation of beta approximation. Vf should apply after beta:

beta = <F>^2/<F^2>
I = Vf (<F^2> + beta*(S - 1))

but within the current infrastructure the Vf parameter needs to be processed within the call to F(q). For the purposes of the beta approximation, we must return sqrt(Vf)*<F> and Vf*<F^2> to apply within the calculation of F and F2 so that it cancels in calculation of beta. This is done within the vesicle model, for example.

Incorporating sqrt(Vf) into F may cause difficulties for future uses of F; it may also be confusing to users who are expecting that F should equal 1 at q=0, but they will already be confused by the presence of the contrast term with within the calculation of F.

comment:9 Changed 3 months ago by toqduj

Is this linked or separate from working in absolute units? Otherwise a radio button stating "data is in absolute units; scale is volume fraction" might be an option? I know it is not strictly necessary for the volume fraction in a structure factor calculation…

Note: See TracTickets for help on using tickets.