Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#984 closed defect (fixed)

PDF reports are not being properly generated on Windows

Reported by: smk78 Owned by:
Priority: blocker Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

4.1.1 is generating empty PDF reports on W8.1 (tested by gonzalezm) & W10 (tested by smk78 & butler), but reports are fine on MacOS 10.11 (tested by wojciech).

Win log file reports:

2017-08-02 10:30:19,621 ERROR Report string expected 'name: value' but got u'
2017-08-02 10:30:52,127 ERROR Error creating pdf: No module named common

Problem was not present in 4.1. Though, interestingly, the log file still gives the first (but not the second) error above…

Change History (3)

comment:1 Changed 4 years ago by smk78

krzywon notes:

Looking through the logs of the Windows build for the 4.1.1 release, the xhtml2pdf package for generating pdf files was never bundled. This is probably why the PDFs aren't being created. The OSX job bundled the package as expected.

comment:2 Changed 4 years ago by butler

  • Resolution set to fixed
  • Status changed from new to closed

There was a bit more to it including a path typo. Fixed in branch 4.1.1_path_issues and pulled into 4_1_issues and eventually released as 4.1.2

4.1.2 has been tested and PDF now works again as does master builds though 4.1.1 and 4.1.2 changes have not yet been merged into master. Nonetheless am closing this ticket as fixed

comment:3 Changed 4 years ago by krzywon

In da9b23921df41d99e3b43e2bba26803e24afece2/sasview:

Ignore blank lines when reporting results. refs #984

Note: See TracTickets for help on using tickets.