Opened 2 years ago

Closed 2 years ago

#855 closed defect (fixed)

Corfunc Perspective and file converter tool not bundling into distributed executable

Reported by: butler Owned by: krzywon
Priority: blocker Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Originally reported by Steve King.

The two perspectives added by Lewis O'dricoll in the summer of 2016 were the corfunc perspective which implemented much of the old CCP13 corfunc functionality into SasView and the file_converter which really should be a tool rather than perspective that allows for a few file formats to be converted to canSAS standard format.

These work fine when run from python (assuming the environment is set up correctly) but do not run from the executable builds. The startup sasview.log file says

2017-02-20 10:56:33,947 ERROR SasView: could not find File Converter plug-in module
2017-02-20 10:56:33,947 ERROR Traceback (most recent call last):
  File "sasview.py", line 170, in __init__
ImportError: No module named file_converter

while for corfunc it only has

2017-02-20 10:56:33,946 ERROR Unable to load corfunc module

Some other notes:

  • Looking in ProgramFIles(x86)\SasView\library-zip\sas\sascalc all folders are there except for the corfunc folder (file_converter folder does exist)
  • Looking in ProgramFIles(x86)\SasView\library-zip\sas\sasgui both corfunc and file_converter folders are missing (all the others are there)
  • Looking at the jenkins console both corfunc and file_converter seem to pass just fine with the only obvious warning about documentation for those not being in the toctree

Suspect something is missing in setup_exe and setup_mac but not sure what

Change History (5)

comment:1 Changed 2 years ago by smk78

  • Priority changed from major to blocker

comment:2 Changed 2 years ago by smk78

Priority upgraded to blocker. We cannot release 4.1 without Corfunc (its presence has already been advertised!)

comment:3 Changed 2 years ago by smk78

  • Owner set to krzywon
  • Status changed from new to assigned

comment:4 Changed 2 years ago by krzywon

In 1e13b539370619f0f420c675af3d469eec215af3/sasview:

Modify setup.py to include all of the corfunc and file_converter perspecitves. Also modified an erroneous include in the pr perspective. #855

comment:5 Changed 2 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 18da4a8d448943c44c25206babe37268feb04cbd/sasview:

Merge pull request #35 from SasView?/ticket-855

ticket-855: Modify setup.py to include file_converter and corfunc in Jenkins build. Fixes #855

Note: See TracTickets for help on using tickets.