Opened 8 years ago
Closed 8 years ago
#827 closed defect (fixed)
save project/analysis on 2D fits is broken
Reported by: | pkienzle | Owned by: | krzywon |
---|---|---|---|
Priority: | minor | Milestone: | SasView 4.1.0 |
Component: | SasView | Keywords: | |
Cc: | Work Package: | SasView Bug Fixing |
Description
project/analysis save does not work for 2D fit pages.
The immediate issue is that self.version is not defined in fitting PageState?, giving the version number of the cansas schema for 2D data. Easy enough to avoid this error, however, the schema itself,
http://svn.smallangles.net/svn/canSAS/1dwg/trunk/cansas1d.xsd
is not available, so the resulting file would not be valid.
Change History (8)
comment:1 Changed 8 years ago by pkienzle
comment:2 Changed 8 years ago by krzywon
- Owner set to krzywon
- Status changed from new to assigned
comment:3 Changed 8 years ago by krzywon
comment:4 Changed 8 years ago by krzywon
comment:5 Changed 8 years ago by krzywon
comment:6 Changed 8 years ago by krzywon
I have issued a pull request (30) for this ticket. I have not tested if this conflicts with the changes I made for #795, but that is my next step.
comment:7 Changed 8 years ago by krzywon
I have merged branches ticket-795 (#795) and ticket-827 into a single cohesive branch as well as one pull request (https://github.com/SasView/sasview/pull/30). The original pull request for ticket-795 (https://github.com/SasView/sasview/pull/22) is now closed, but the comments are still relevant to the work done.
comment:8 Changed 8 years ago by GitHub <noreply@…>
- Resolution set to fixed
- Status changed from assigned to closed
Note: requires branch ticket-811 to test.