Opened 4 years ago

Closed 4 years ago

#827 closed defect (fixed)

save project/analysis on 2D fits is broken

Reported by: pkienzle Owned by: krzywon
Priority: minor Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

project/analysis save does not work for 2D fit pages.

The immediate issue is that self.version is not defined in fitting PageState?, giving the version number of the cansas schema for 2D data. Easy enough to avoid this error, however, the schema itself,

http://svn.smallangles.net/svn/canSAS/1dwg/trunk/cansas1d.xsd

is not available, so the resulting file would not be valid.

Change History (8)

comment:1 Changed 4 years ago by pkienzle

Note: requires branch ticket-811 to test.

comment:2 Changed 4 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to assigned

comment:3 Changed 4 years ago by krzywon

In 83c09af62d5011f226defc52e4715b83e6494e0f/sasview:

Fit states and projects are now able to save 2D data. Loading is still not working. #827

comment:4 Changed 4 years ago by krzywon

In af08e55a12fe753ae7a904c4876a757795017deb/sasview:

Saving and loading of 2D data within projects and fit save states is working. This works alongside saving and loading 1D fits withint the same .svs file. #827

comment:5 Changed 4 years ago by krzywon

In 1905128f490ecfb000981307cc0003085ab415e5/sasview:

Speed up saving and loading 2D data in save states by putting all data into a single <Idata> and linearizing it. #827

comment:6 Changed 4 years ago by krzywon

I have issued a pull request (30) for this ticket. I have not tested if this conflicts with the changes I made for #795, but that is my next step.

comment:7 Changed 4 years ago by krzywon

I have merged branches ticket-795 (#795) and ticket-827 into a single cohesive branch as well as one pull request (https://github.com/SasView/sasview/pull/30). The original pull request for ticket-795 (https://github.com/SasView/sasview/pull/22) is now closed, but the comments are still relevant to the work done.

comment:8 Changed 4 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 2510b9b9dd6b1865d897555b1fd71086a65f89d7/sasview:

Merge pull request #30 from SasView?/ticket-827

Fixes #795, #819, #827, #847

Note: See TracTickets for help on using tickets.