Opened 8 years ago
Last modified 7 years ago
#812 accepted enhancement
Provide model for the Pringle-Schmidt helical form factor
Reported by: | smk78 | Owned by: | tim |
---|---|---|---|
Priority: | minor | Milestone: | SasView 4.3.0 |
Component: | sasmodels | Keywords: | |
Cc: | Work Package: | SasModels New Model |
Description
Request from Ian Hamley (i.w.hamley@…):
Would be possible to incorporate the Pringle-Schmidt helical form factor into SasView? It is used in quite a few studies now. There are other helical form factors (see attached) but the Pringle-Schmidt form factor is more generally and more widely used.
I don’t have code although I know some people who might – Heinz Amenitsch or Pierre Terech. These two groups also have data and fits in their papers.
I have datasets waiting to be fitted, as does Daniel Hermida-Merino at the ESRF.
Attachments (3)
Change History (11)
Changed 8 years ago by smk78
comment:1 Changed 8 years ago by tim
- Owner set to tim
- Status changed from new to accepted
comment:2 Changed 8 years ago by butler
- Priority changed from major to minor
Given the existence of the marketplace as a distribution mechanism and the impact to 4.1 this could easily be moved to 4.2 and should not impact the release of 4.1. Will leave here for now as work is ongoing and depending on when the freeze is this could make it in.
comment:3 Changed 8 years ago by butler
- Component changed from sasmodels to sasmodels Markeplace
- Milestone changed from SasView 4.1.0 to Admin Tasks
comment:4 Changed 8 years ago by smk78
Tim has coded a model and uploaded it to the Marketplace. (But has been unable to upload an example dataset because of Ticket #685)
Ian has been told the model is available and has been given instruction on how to implement and use it. We await feedback from him!
If/when the model is given the thumbs up it should be added to the sasmodels library.
comment:5 Changed 8 years ago by tim
I have now heard from Ian and he is using the model with some of his data. Presuming that this returns a sane result then this ticket can be closed.
comment:6 Changed 8 years ago by butler
- Milestone changed from Admin Tasks to SasView 4.1.0
comment:7 Changed 8 years ago by butler
- Component changed from sasmodels Markeplace to sasmodels
- Milestone changed from SasView 4.1.0 to SasView 4.2.0
This is available in the marketplace and at any rate in no way a blocker for this release.Given the imminent freeze for a 4.1 release am going ahead and moving this to 4.2.
comment:8 Changed 7 years ago by butler
- Milestone changed from SasView 4.2.0 to SasView 4.3.0
Original Pringle-Schmidt paper (1971)