Opened 2 years ago
Last modified 3 weeks ago
#791 new enhancement
make fractal a structure factor model
Reported by: | pkienzle | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | SasView 4.3.0 |
Component: | sasmodels | Keywords: | |
Cc: | Work Package: | SasModels Model Issues |
Description
Currently fractal and core_shell_fractal are implemented as P(q) * S(q), where P(q) is the sphere structure factor for fractal or the core shell sphere for core_shell_fractal and S(q) is the fractal structure factor.
Propose splitting the S(q) into its own structure factor model so that all variants of fractal clustering are supported at once.
Change History (4)
comment:1 Changed 2 years ago by butler
- Milestone changed from SasView 4.1.0 to SasView 4.2.0
comment:2 Changed 13 months ago by butler
- Milestone changed from SasView 4.2.0 to SasView 4.3.0
comment:3 Changed 4 weeks ago by butler
Closed ticket #1168 which was essentially a duplicate. Some thoughts from that ticket:
Since all our fractal models are simply one of our form factors multiplied by the Teixeira Structure factor we should pull out the Teixeira fractal SQ and name it as such (i.e. teixera_fractal_sq). This distinguishes from other fractal models we may want to add. Eventually we may then want to remove the two/three existing combo fractals. 5.0 might the time to remove the old combos since that will break backward compatibility with saved projects and plugins that use the old models?
comment:4 Changed 3 weeks ago by butler
- Work Package changed from SasModels New Model to SasModels Model Issues
This can be done in two pieces — treating the model as such in the background allows for cleaner reuse of code. PK says this has been done in his branch and should be implemented in 4.1. The second part is to present this to the user as independent structure factor. This may well be a good idea, but there is concern about how to distinguish different approaches to the fractal Sq and how users will know what to do. This requires some thinking and discussion before implementing so moving this to 4.2 for now