Opened 5 years ago

Closed 5 years ago

#777 closed defect (fixed)

Verify if ESS 4.1 builds are properly linking to page anchors in help documentation

Reported by: smk78 Owned by: wojciech
Priority: critical Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

In local builds of 4.1 some Help buttons on GUIs are ignoring page anchors in the Wx code in the .py files and are only linking to the top of a given help file. Whereas in release 3.1.2 the Help button jumps to the relevant place in the help file.

In the code one often finds this comment::

Calls DocumentationWindow with the path of the location within
the documentation tree (after /doc/ ….". Note that when using
old versions of Wx (before 2.9) and thus not the release version of
installers, the help comes up at the top level of the file as
webbrowser does not pass anything past the # to the browser when it
is running "file:///…."

However, even local builds against Wx 3.0 are failing, so it is not just a earlier Wx issue.

The behaviour of build server builds needs to be checked.

A simple way to do this is to go Fitting > Plugin Model Operations > New Plugin Model and click the Help button. If it directs you to the top of the Fitting help (you will see the title 'Fitting') the problem exists. If it directs you to New Plugin Model the build is ok.

Change History (5)

comment:1 Changed 5 years ago by smk78

Just tested ESS Win 7 build 583 and it is ignoring page anchors (it just goes to the top of the file). :-(

comment:2 Changed 5 years ago by wojciech

  • Owner set to wojciech
  • Status changed from new to assigned

comment:3 Changed 5 years ago by wojciech

In a08b89bdf5a13632196725c27a97760f06d09e9c/sasview:

Fixing new plugin editor link anchor. Related to #777

comment:4 Changed 5 years ago by wojciech

The link to New Plugin Model has been fixed.
Trying to set up an automatic check for broken links to see if there are more failing cases.

comment:5 Changed 5 years ago by wojciech

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.