Opened 8 years ago
Closed 8 years ago
#675 closed enhancement (fixed)
Reparameterize hollow_cylinder
| Reported by: | butler | Owned by: | richardh |
|---|---|---|---|
| Priority: | major | Milestone: | SasView 4.1.0 |
| Component: | SasView | Keywords: | |
| Cc: | Work Package: | SasModels Redesign |
Description
hollow cylinder currently uses R_core and R_shell where R_shell is the outer radius. This makes fitting, particularly with polydispersity problematic as R_shell can then go below R_core (or the distribution gets cut in odd way). Most other core shell models are parameterized as a R_core and thickness of shell.
Note that doing this will break saved projects using the old parameters unless we do something special.
Change History (2)
comment:1 Changed 8 years ago by richardh
- Owner set to richardh
- Status changed from new to accepted
comment:2 Changed 8 years ago by richardh
- Resolution set to fixed
- Status changed from accepted to closed
Note: See
TracTickets for help on using
tickets.
original hollow_cylinder replaced by new version where parameters are now core radius and shell thickness, not outer radius and core radius.
Yes this will break any previously saved models.