#674 closed defect (fixed)

custom model name and id must be the same

Reported by: pkienzle Owned by: mathieu
Priority: major Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

The id for the model comes from the filename, and can be used to find and load the model on the path. The name for the model is the name displayed in the dialog box, which need not match the name of the python file.

If the name and id differs for a custom model then custom model directory processing halts with an error such as the following:

2016-09-29 07:51:39,932 ERROR Traceback (most recent call last):
  File "/Users/pkienzle/Source/sasview-new/src/sas/sasgui/perspectives/fitting/basepage.py", line 1882, in _show_combox_helper
    m_list.append(self.model_dict[str_m])
KeyError: 'myonion'

and the remaining custom models will not appear in the SasView gui.

For the file model_name.py, id is model_name and name defaults to "Model Name". We may want to change this default behaviour (defined in sasmodels/modelinfo.py:make_model_info).

Change History (3)

comment:1 Changed 14 months ago by mathieu

This has been fixed by #732

comment:2 Changed 14 months ago by mathieu

  • Owner set to mathieu
  • Status changed from new to accepted

comment:3 Changed 14 months ago by mathieu

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.