Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#400 closed defect (fixed)

DAB model equation in model function help file is wrong!

Reported by: smk78 Owned by: butler
Priority: critical Milestone: SasView 3.1.1
Component: SasView Keywords:
Cc: Work Package: SasModels Redesign

Description

There is a typo in the expression for I(q) for the DAB model (which was
present in the original html model help file)!

The outer set of brackets in the denominator need to be raised to the
power of 2 so that the limiting behaviour of the function is 1/q4.

Change History (8)

comment:1 Changed 4 years ago by butler

once fixed in release move to +1 and check in sasmodels

comment:2 Changed 4 years ago by butler

  • Owner set to smk78
  • Status changed from new to assigned

comment:3 Changed 4 years ago by butler

This needs to be changed TWO places. Given we are in code freeze and release only mode, only changing the rst files is required now. Once done the ticket should be so noted and moved to release 4.0 where the changed text will need to move to the sasmodel code which has already been converted with wrong documentation.

comment:4 Changed 4 years ago by smk78

Corrected equation image (image180_corrected.PNG) pushed to repo.

model_functions.rst updated to pick up the new image.

comment:5 Changed 4 years ago by smk78

  • Milestone changed from SasView 3.1 to SasView Next Release +1
  • Work Package changed from SasView Documentation to SasModels Redesign

Model equation in sasmodel file now needs updating. This can wait until release 4.0.

comment:6 Changed 4 years ago by butler

  • Owner changed from smk78 to butler
  • Status changed from assigned to accepted

comment:7 Changed 4 years ago by butler

  • Resolution set to fixed
  • Status changed from accepted to closed

So looks like primary equation in sasmodels had been corrected already. However the full current documentation had not been properly ported so that was done. the docs now match the SasView models documentation.

However it seems the details string of the current SasView version (as opposed to the rst file) does not include the L3 term so have fixed that as well. We can now close this ticket

comment:8 Changed 4 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 3.1.1
Note: See TracTickets for help on using tickets.