Opened 3 years ago

Closed 3 years ago

#265 closed defect (fixed)

Investigate why Image Viewer tool is not loading .TIF or .BMP

Reported by: smk78 Owned by:
Priority: critical Milestone: SasView 3.1.0
Component: SasView Keywords: .TIF, .BMP, File Extension
Cc: Work Package: SasView Bug Fixing

Description

Paul said on 31 May:

It seems that jpg, png, and gif work but that bmp and tiff currently
do not.

Attachments (6)

test_bmp.bmp (62.3 KB) - added by krzywon 3 years ago.
Test BMP file
test_gif.gif (10.7 KB) - added by krzywon 3 years ago.
Test GIF file
test_jpg.jpg (36.5 KB) - added by krzywon 3 years ago.
Test JPG File
test_png.png (7.5 KB) - added by krzywon 3 years ago.
Test PNG File
test_tiff.tif (20.3 KB) - added by krzywon 3 years ago.
Test Tiff Full Color File
test_tiff_bw.tif (21.9 KB) - added by krzywon 3 years ago.
Test Tiff Black And White File

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by butler

On further investigation, this works on my development system (windows 8.1 laptop with packages as given in ticket #213 Table. It does not work however in the exe bundle.

imageviewer.py in the guiframe package seems to be doing the work and is using matplotlib.image.imread to load the files. My matplotlib is 1.3 instead of the 1.1. on the build system. However this code was introduced by Jae Hie about a year ago (probably using 0.98?) so not likly to be cuplrit? Looking for dependencies that might be a problem I found an article which suggests that only PNG is natively supported by matplotlib and that the other formats rely on PIL — but my system (which works) does not have PIL while the build system (which seems not to work) does have PIL.

comment:2 Changed 3 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 3.0.1

comment:3 Changed 3 years ago by ajj

  • Work Package set to SasView Bug Fixing

Changed 3 years ago by krzywon

Test BMP file

Changed 3 years ago by krzywon

Test GIF file

Changed 3 years ago by krzywon

Test JPG File

Changed 3 years ago by krzywon

Test PNG File

Changed 3 years ago by krzywon

Test Tiff Full Color File

Changed 3 years ago by krzywon

Test Tiff Black And White File

comment:4 Changed 3 years ago by krzywon

I can load and manipulate all of the image files attached to this ticket using the most recent trunk version of SasView?. The images are all the same 2D data set converted into various image types. Are there any images that still are not working?

comment:5 Changed 3 years ago by mathieu

The images load on my Mac. The only problem I have is that the wildcards used in the dialog won't let you select any file. All files on the Mac file dialog are grayed out and there's no way to change the file extension filter. Apparently the support for wildcards isn't great with wx (at least according to their docs). I'll change it to load any file, but with better error catching (there is none at the moment).

comment:6 Changed 3 years ago by mathieu

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.