Opened 3 years ago

Closed 3 years ago

#210 closed defect (fixed)

Problem with Box Averaging in Qx

Reported by: butler Owned by: krzywon
Priority: major Milestone: SasView 3.0.0
Component: SasView Keywords:
Cc: Work Package:

Description

Alexander Grutter of NIST reports "I’ve been having issues with the binning when using the “Box Averaging in Qx” function. When interacting with a 2D plot and attempting to average a rectangular box, the number of points output does not seem to correspond to the number of requested bins. For example, if I select “edit slicer parameters” and ask for 64 bins, I will get some random number of points between 100-130. Upon trying to return to the default number of bins, nothing will happen. If I then request something simple such as 1-2 bins, I get something like 5-6 points. None of this happens when using the ““Box Averaging in Qy” function.

This issue is produced on both v2.2.1 and the latest development version available online."

I have verified this is the case also with the 2D data in the test folder. Once fixed Alex should be notified (at alexander.grutter@…) as part of the resolution to this ticket.

Change History (2)

comment:1 Changed 3 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to accepted

comment:2 Changed 3 years ago by krzywon

  • Resolution set to fixed
  • Status changed from accepted to closed

The directionality of the averaging was not passed forward when the averaging parameters were changed, causing this issue. The default averaging direction was in the Y direction, so any averaging done once the box was set was in the Y direction. I added a class variable called direction to the BoxInteraction? class that is set the first time the box averaging is called.

After testing with an anisotropic data set, the Qx and Qy averages are different and can be modified separately.

Note: See TracTickets for help on using tickets.