Opened 9 months ago

Closed 8 months ago

Last modified 6 months ago

#1205 closed defect (fixed)

4.2 set weighting choice seems to be ignored.

Reported by: richardh Owned by: mathieu
Priority: blocker Milestone: SasView 4.2.1
Component: SasView Keywords:
Cc: Work Package: SasView QA and testing

Description

Comparing fit results between 4.2 and 5.0, noticed (see #1204) that the set weighting option in 4.2 has no effect on the fit results, whereas it does in 5.0

Further investigation required.

Change History (9)

comment:1 Changed 9 months ago by smk78

Changing the weighting option does change the appearance of the residuals plot.

Moreover, if you sub-select and fit a region of the data with poorer error bars you DO find that the fit parameters change markedly depending on the weighting scheme chosen. For example, load the ISIS_Polymer_Blend_RT2 data and limit the fitted region to between 0.15 - 0.254. As you include more and more of the data below 0.15 the fit parameters vary less with the weighting scheme chosen as @richardh describes.

comment:2 Changed 9 months ago by richardh

In the test I did the cylinder length stayed around 160.5 ang regardless of weighting scheme in 4.2, but in 5.0 was 160.5 (weights dI), 104 (weights none), 148 (sqrtI) and 205 (weights I(Q)) ang. So what is 5.0 doing differently, or is 4.2 acting up? 

comment:3 Changed 9 months ago by richardh

3.1.2 and 4.1.2 behave in same way for me as 4.2, so perhaps the issue lies in 5.0 after all?

comment:4 Changed 8 months ago by butler

  • Priority changed from critical to blocker

comment:5 Changed 8 months ago by pkienzle

Issue confirmed for current master.

Change the weighting and hit compute and the residuals plot is updated appropriately, however, the fit seems to use the data weights regardless of the GUI setting.

comment:6 Changed 8 months ago by Paul Kienzle <pkienzle@…>

In a5cffe570a689752aa7b74ce8a71d2b1704e624f/sasview:

re-enable fitting using weights defined in the GUI. Refs #1205.

comment:7 Changed 8 months ago by pkienzle

Sasview PR# 199.

comment:8 Changed 8 months ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 4e373abb866e1d6eba7f4b6db5db200f431170fb/sasview:

Merge pull request #199 from SasView?/ticket-1205-fit-weights

Ticket 1205: use data weights from the GUI in the fit. Closes #1205

quick testing looks fine so going to merge.

comment:9 Changed 6 months ago by butler

  • Milestone changed from SasView 4.3.0 to SasView 4.2.1
Note: See TracTickets for help on using tickets.