Opened 5 months ago

Closed 4 weeks ago

#1137 closed defect (fixed)

QT GUI - Creating a sum/multi model causes crash (in sasmodels code)

Reported by: tcbennun Owned by:
Priority: blocker Milestone: SasView 5.0.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

In 5.0, trying to create a new sum/multiply model seems to always result in an exception being raised in sasmodels, at model_test.py:396.

When a sum/multi model is created, model unit tests are immediately run. After this, the test suite is checked for user-made tests. This executes fine in Python 2 / SasView? 4.x.

In Python 3 / SasView? 5.x, we run into an error at this stage because all the tests within the unit test suite have been set to None in the process of running the test suite (this is visible in the Python unittest source code).

Some difference in the unittest module between Python 2 and 3 has caused the behaviour to change, causing the crash.

Change History (5)

comment:1 follow-up: Changed 5 months ago by piotr

This is known - please use the ESS_dev branch in sasmodels.
The commit there explains the issue.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 5 months ago by tcbennun

Replying to piotr:

This is known - please use the ESS_dev branch in sasmodels.
The commit there explains the issue.

Whoops, okay thanks!

Should this change be merged into master?

comment:3 in reply to: ↑ 2 Changed 5 months ago by piotr

Replying to tcbennun:

Replying to piotr:

This is known - please use the ESS_dev branch in sasmodels.
The commit there explains the issue.

Whoops, okay thanks!

Should this change be merged into master?

Yeah, I will issue the merge request. Thanks for reminding me about this.

comment:4 Changed 4 weeks ago by piotr

Been fixed for some time already. Marking accordingly.

comment:5 Changed 4 weeks ago by piotr

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.