Opened 5 months ago

Closed 4 months ago

#1136 closed defect (fixed)

QT5 GUI - rename FitPage0 to Fitpage1 or rename M1 to M0

Reported by: richardh Owned by: richardh
Priority: major Milestone: SasView 5.0.0
Component: SasView Keywords:
Cc: Work Package: Beta Approximation Project

Description

The first FitPage in the QT gui is FitPage0 but has models M1 and parameters M1.radius etc. This will make constraints very confusing!

Suggest rename one or the other, preferably to my mind start at FitPage1 for backwards compatibility with earlier versions.

(putting this in beta approx project for now, though is not really part of this)

Change History (5)

comment:1 Changed 5 months ago by tcbennun

I agree with starting at FitPage1, and it's a one-line fix, so I think I'll be bold and put it through…

comment:3 follow-up: Changed 5 months ago by piotr

FittingPerspectiveTest.py will also need to modified

Last edited 5 months ago by piotr (previous) (diff)

comment:4 in reply to: ↑ 3 Changed 5 months ago by tcbennun

Replying to piotr:

FittingPerspectiveTest.py will also need to modified

Of course, cheers. Done.

comment:5 Changed 4 months ago by richardh

  • Resolution set to fixed
  • Status changed from new to closed

Has been done, so closing this ticket.

Note: See TracTickets for help on using tickets.