#1013 closed defect (fixed)

FileReaderBaseClass output[] not reset - same file loaded multiple times

Reported by: krzywon Owned by: GitHub <noreply@…>
Priority: critical Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

The new FileReaderBaseClass? is not resetting class variables when loading subsequent data sets. The output class variable stores loaded data sets in a list and is one of the variables that is not reset between loads. When a new data set is loaded, all previously loaded data sets are loaded again.

This is true for the ASCII reader and red2d readers, at least. The CansasXML and NXcanSAS readers have built in methods to handle this issue, but having a top level class method would be better.

Work flow to show the issue:
(1) Load in any test 2D data file with the .dat file extension. A single data set will appear in the data explorer.
(2) Load in any other .dat file. Two more data sets will appear in the explorer, the file loaded in (1) will load again and the new one will as well. 3 data sets appear in the list.

Change History (1)

comment:1 Changed 22 months ago by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 3d950a95233b3ed5db333864e708cb2ebe05bf14/sasview:

Merge pull request #111 from SasView?/ticket-1013

Ticket 1013 - Reset FileReader? class state on every data load
Closes #1013

Note: See TracTickets for help on using tickets.