Changeset 9235fc3 in sasmodels


Ignore:
Timestamp:
Sep 28, 2018 7:48:06 AM (3 months ago)
Author:
richardh
Branches:
master, beta_approx, cuda-test, py3, ticket-1015-gpu-mem-error, ticket-1015-quick-fix, ticket-1157, ticket-608-user-defined-weights, ticket_1156
Children:
c78d677
Parents:
d8b4c5a
Message:

further changes to be_polyelectrolyte validation doc

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sasmodels/models/be_polyelectrolyte.py

    rd8b4c5a r9235fc3  
    6464dimensionally useful units of 1/|Ang|^3, only the converted version of the 
    6565polymer concentration was actually being used in the calculation while the 
    66 unconverted salt concentration (still in units of mol/L) was being used.  This 
    67 was carried through to sasmodels today (except that the line of code converting 
    68 the salt concentration to the new units was dropped somewhere along the line). 
    69 Simple dimensional analysis of the calculation shows that it is in fact the 
    70 converted salt concentration must be used and the original code suggests that 
    71 was the intention.  We therefore believe this is now correct. Once better 
     66unconverted salt concentration (still in apparent units of mol/L) was being used.  This 
     67was carried through to sasmodels as used for sasview 4.1(though the line of code converting 
     68the salt concentration to the new units was removed somewhere along the line). 
     69Simple dimensional analysis of the calculation shows that the 
     70converted salt concentration should be used, which the original code suggests 
     71was the intention, so this has now been corrected (for sasview 4.2). Once better 
    7272validation has been performed this note will be removed. 
    7373 
Note: See TracChangeset for help on using the changeset viewer.