Changeset 9235fc3 in sasmodels for sasmodels/models/be_polyelectrolyte.py

Timestamp:

Sep 28, 2018 5:48:06 AM (6 years ago)

Author:

richardh

Branches:

master, core_shell_microgels, magnetic_model, ticket-1257-vesicle-product, ticket_1156, ticket_1265_superball, ticket_822_more_unit_tests

Children:

c78d677

Parents:

d8b4c5a

Message:

further changes to be_polyelectrolyte validation doc

File:

• sasmodels/models/be_polyelectrolyte.py (modified) (1 diff)

sasmodels/models/be_polyelectrolyte.py

@@ -64 +64 @@
 dimensionally useful units of 1/|Ang|^3, only the converted version of the
 polymer concentration was actually being used in the calculation while the
-unconverted salt concentration (still in units of mol/L) was being used.  This
-was carried through to sasmodels today (except that the line of code converting
-the salt concentration to the new units was dropped somewhere along the line).
-Simple dimensional analysis of the calculation shows that it is in fact the
-converted salt concentration must be used and the original code suggests that
-was the intention.  We therefore believe this is now correct.  Once better
+unconverted salt concentration (still in apparent units of mol/L) was being used.  This
+was carried through to sasmodels as used for sasview 4.1(though the line of code converting
+the salt concentration to the new units was removed somewhere along the line).
+Simple dimensional analysis of the calculation shows that the
+converted salt concentration should be used, which the original code suggests
+was the intention, so this has now been corrected (for sasview 4.2). Once better
 validation has been performed this note will be removed.