Changeset 3c56da87 in sasmodels for extra

Timestamp:

Mar 5, 2015 12:55:38 AM (9 years ago)

Author:

Paul Kienzle <pkienzle@…>

Branches:

master, core_shell_microgels, costrafo411, magnetic_model, release_v0.94, release_v0.95, ticket-1257-vesicle-product, ticket_1156, ticket_1265_superball, ticket_822_more_unit_tests

Children:

3a45c2c

Parents:

b89f519

Message:

lint cleanup

Location:

extra

Files:

• pylint.rc (modified) (6 diffs)
• pylint_numpy.py (added)
• pylint_pyopencl.py (added)
• run-pylint.py (modified) (1 diff)

extra/pylint.rc

@@ -20 +20 @@
 # List of plugins (as comma separated values of python modules names) to load,
 # usually to register additional checkers.
-load-plugins=
+load-plugins=pylint_numpy,pylint_pyopencl
 
 # Use multiple processes to speed up Pylint.
-jobs=4
+#jobs=4
 
 # Allow loading of arbitrary C extensions. Extensions are imported into the
@@ -57 +57 @@
 
 # Disable the message(s) with the given id(s).
-disable=W0702,W0613,W0703,W0142
+# http://pylint-messages.wikidot.com/all-codes
+disable=
+    multiple-statements,
+    global-statement,
+    bare-except,
+    broad-except,
+    bad-whitespace,
+    bad-continuation,
+    too-many-statements,
+    too-many-branches,
+    too-many-locals,
+    too-many-instance-attributes,
+    too-many-arguments,
+    star-args,
+    unbalanced-tuple-unpacking,
+    locally-disabled,
+    old-style-class,
 
 [REPORTS]
@@ -98 +114 @@
 
 # Good variable names which should always be accepted, separated by a comma
-good-names=i,j,k,ex,Run,_,x,y,z,qx,qy,qz,n,q,dx,dy,dz,id,Iq,dIq,Qx,Qy,Qz
+good-names=_,
+    input,
+    i,j,k,n,x,y,z,
+    q,qx,qy,qz,
+    dt,dx,dy,dz,id,
+    Iq,dIq,Qx,Qy,Qz,
+    p,
+    ER, call_ER, VR, call_VR,
 
 # Bad variable names which should always be refused, separated by a comma
@@ -111 +134 @@
 
 # Regular expression matching correct function names
-function-rgx=[a-z_][a-z0-9_]{2,30}$
+function-rgx=[a-z_][a-z0-9_]{2,30}([123]D)?$
 
 # Naming hint for function names
@@ -172 +195 @@
 # Regular expression which should only match function or class names that do
 # not require a docstring.
-no-docstring-rgx=__.*__
+#no-docstring-rgx=__.*__
+no-docstring-rgx=_.*
 
 # Minimum line length for functions/classes that require docstrings, shorter
@@ -181 +205 @@
 
 # Maximum number of characters on a single line.
-max-line-length=100
+#max-line-length=100
+max-line-length=80
 
 # Regexp for a line that is allowed to be longer than the limit.
-ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+#ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+# No comma in the last forty characters
+ignore-long-lines=([^-,+*/]{40},?|[^"]{40}")$
 
 # Allow the body of an if to be on the same line as the test if there is no

extra/run-pylint.py

@@ -4 +4 @@
 
 def main():
+    envpath = os.environ.get('PYTHONPATH',None)
+    path = [envpath] if envpath else []
+    path.append(abspath(dirname(__file__))) # so we can find the plugins
+    os.environ['PYTHONPATH'] = ':'.join(path)
     root = abspath(joinpath(dirname(__file__), '..'))
     os.chdir(root)
-    cmd = "pylint --rcfile extra/pylint.rc -f parseable sasmodels > pylint_violations.txt"
+    cmd = "pylint --rcfile extra/pylint.rc -f parseable sasmodels"
     status = os.system(cmd)
     sys.exit(status)