Opened 8 years ago

Last modified 7 years ago

#942 new defect

Need to Refactor SimultaneousFitPage Class

Reported by: butler Owned by:
Priority: trivial Milestone: SasView 5.0.0
Component: SasView Keywords:
Cc: Work Package: SasView Framework Enhancements

Description

It turns out that the SimultaneousFitPage class in simfitpage.py is used both for constrained/simultaneous fitting and for combined batch fitting. Most of th page is the same but there are a dozen instances requiring one or two lined of code change that are all done using "if batch_on…."

This is bad form. Ideally the class should be rewritten to be generic and then two subclasses written which inherit from that class. All could reside in the one file.

However, since this is in sasgui which goes away soon and does not affect the user experience it has a trivial priority and will presumably be closed as obsolete after 5.0 if not fixed first.

Change History (1)

comment:1 Changed 7 years ago by butler

  • Milestone changed from SasView 4.2.0 to SasView 5.0.0

No point in doing this in old gui. Probably irrelevant in new GUI but move to 5.0 for now anyway?

Note: See TracTickets for help on using tickets.