Opened 3 years ago
Closed 3 years ago
#877 closed task (fixed)
What did 3.1.2 do with polydispersity in the Fractal Model; what should 4.2 do?
Reported by: | smk78 | Owned by: | butler |
---|---|---|---|
Priority: | critical | Milestone: | SasView 4.1.0 |
Component: | SasView | Keywords: | |
Cc: | Work Package: | SasView Bug Fixing |
Description
Greg Newbloom & Adrian Rennie have both commented on the removal of polydispersity on the radius parameter in the fractal model in 4.0.1. It was allowed in earlier versions.
The fractal S(Q) in this model also includes the radius parameter (as well as the spherical P(Q)).
So there are two questions:
- Did 3.1.2 and earlier versions only apply polydispersity to P(Q), or to P(Q) and S(Q)?
- Should polydispersity be put back into this model for 4.2?
Change History (2)
comment:1 Changed 3 years ago by butler
- Milestone changed from SasView 4.2.0 to SasView 4.1.0
- Owner set to butler
- Status changed from new to assigned
comment:2 Changed 3 years ago by butler
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
Clearly my fault. The git record clearly shows that I converted this model and failed to make radius a volume parameter, while Piotr converted the fractal core-shell and DID make radius and thickness polydisperse. Clearly this was done as an oversight not deliberately due to some deep problem. I will correct this for 4.1