Opened 2 years ago

Closed 2 years ago

#870 closed defect (fixed)

S(Q) broken?

Reported by: richardh Owned by: pkienzle
Priority: blocker Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

As Paul B also reported, my latest pulls to windows & then build, won't let me use S(Q), hangs sasview. Errors in github console: I am guessing Jeff might be the expert here???

Traceback (most recent call last):

File "C:\sasview-code\sasview\src\sas\sasgui\perspectives\fitting\fitpage.py", line 1169, in _on_select_model

self._on_select_model_helper()

File "C:\sasview-code\sasview\src\sas\sasgui\perspectives\fitting\basepage.py", line 2050, in _on_select_model_helper

struct_factor())

File "C:\sasview-code\sasmodels\sasmodels\sasview_model.py", line 179, in MultiplicationModel?

structure_factor._model_info)

File "C:\sasview-code\sasmodels\sasmodels\product.py", line 60, in make_product_info

for par in s_pars.kernel_parameters[1:]]

TypeError?: suffix_parameter() takes exactly 2 arguments (1 given)

Change History (3)

comment:1 Changed 2 years ago by krzywon

  • Owner changed from krzywon to pkienzle
  • Status changed from new to assigned

Paul K has already made a change that seems to fix this in sasmodels branch 'ticket-843'. I am giving this ticket to him.

comment:2 Changed 2 years ago by butler

Just tested the latest fixe to branch ticket-843 and it is now working. Was this also failing on master? If so it would have been extremely recently. If it was just this branch then probably would have been more appropriate to just review the ticket and request changes before pulling? Seems like that is what review and approvals on the pull requests are for? to ensure that fixes/new functionality don't break things before merging?

Either way, at this point I would vote that we can wait for ticket-843 to be pulled and master verified to close this?

comment:3 Changed 2 years ago by pkienzle

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.