Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#838 closed defect (fixed)

Fix model download from marketplace

Reported by: tim Owned by: wojciech
Priority: blocker Milestone: SasView 4.2.0
Component: sasmodels Markeplace Keywords:
Cc: Work Package: SasModels Marketplace

Description (last modified by butler)

From email to ajj:

After uploading the Pringle-Schmidt model for Ian to the SasView marketplace online we discovered a small bug with the marketplace file downloader. Although if you click on the file link on the model description page (i.e. it shows the file's contents, however, clicking the link at the bottom of the page returns a file that only contains the text:

'NoneType' object has no attribute 'read'

I have tried this for models 2, 4, 6 & 8 all of which return the same file. Any ideas as to why this is occurring?



Change History (7)

comment:2 Changed 6 years ago by ajj

  • Owner changed from ajj to wojciech
  • Status changed from new to assigned

comment:3 Changed 6 years ago by wojciech

The fix has been pushed but automatic deployment hasn't been triggered. Andrew will look into this.

comment:4 Changed 6 years ago by butler

  • Description modified (diff)

comment:5 Changed 6 years ago by butler

  • Milestone changed from SasView 4.1.0 to SasView 4.2.0

This is really an admin task and not a 4.1 release blocker - though it would be REALLY nice to be able to release 4.1 with announcement of a working marketplace. Still, as we are closing down work on 4.1 release am moving this to 4.2 so as not to confuse things along with ticket #685

comment:6 Changed 6 years ago by smk78

And you can always highlight the code for a model, select, copy, and paste into an editor, so it's not like the models are unattainable. Agree, not a blocker.

comment:7 Changed 6 years ago by ajj

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed by @wojciech in commit 80731868

Last edited 6 years ago by ajj (previous) (diff)
Note: See TracTickets for help on using tickets.