Opened 8 years ago
Last modified 6 years ago
#822 assigned enhancement
Create proper Unit Testing directory structure for SasModels
Reported by: | piotr | Owned by: | richardh |
---|---|---|---|
Priority: | major | Milestone: | SasView 4.3.0 |
Component: | sasmodels | Keywords: | |
Cc: | Work Package: | SasView Framework Enhancements |
Description
Change History (6)
comment:1 Changed 7 years ago by butler
- Milestone changed from SasView 4.2.0 to SasView 4.3.0
- Work Package changed from SasView Bug Fixing to SasView Framework Enhancements
comment:2 Changed 6 years ago by pkienzle
comment:3 Changed 6 years ago by Paul Kienzle <pkienzle@…>
comment:4 Changed 6 years ago by GitHub <noreply@…>
- Owner set to GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed 6 years ago by pkienzle
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening.
The original request wasn't satisfied, which was to restructure sasmodels tests to use proper Unit Testing directory structure.
Python has a variety of "proper" test structures such as:
- embedded: put tests in package/code.py
- sub-package: put tests package/test/code_test.py
- separate: put tests in test/package/code_test.py
and test styles:
- py.test
- nose
- nose2
- unittest
Currently using embedded nose tests which py.test can identify.
Discuss whether this should be changed before closing this ticket.
comment:6 Changed 6 years ago by richardh
- Component changed from SasView to sasmodels
- Owner changed from GitHub <noreply@…> to richardh
- Status changed from reopened to assigned
Created new branch in sasmodels ticket_822_v5_unit_tests, to start adding unit tests for @S(Q) and beta(Q) approx in sasview 5 as per http://trac.sasview.org/ticket/822#comment:2 above, using this ticket number as a reference.
Will assign this ticket to myself for now.
Could extend the test environment within each model file to allow structure factor tests. That way user models can include structure factor evaluations.
something like:
Need some rejiggering of model_test.py, but easy enough.