#804 closed defect (fixed)
rename sas library functions
| Reported by: | pkienzle | Owned by: | wojciech |
|---|---|---|---|
| Priority: | major | Milestone: | SasView 4.1.0 |
| Component: | sasmodels | Keywords: | |
| Cc: | Work Package: | SasView Bug Fixing |
Description
Improve names of sas library functions so that it is easier for the reader to identify what they do. Suggested names:
sph_j1c ⇒ sas_3j1x_x
sas_J1c ⇒ sas_2J1x_x
sinc ⇒ sas_sinx_x
For consistency:
Si ⇒ sas_Si
Change History (6)
comment:1 Changed 8 years ago by wojciech
- Owner set to wojciech
- Status changed from new to assigned
comment:2 Changed 8 years ago by richardh
comment:3 Changed 8 years ago by butler
- Component changed from SasView to sasmodels
- Priority changed from minor to major
comment:4 Changed 8 years ago by GitHub <noreply@…>
comment:5 Changed 8 years ago by wojciech
- Resolution set to fixed
- Status changed from assigned to closed
comment:6 Changed 8 years ago by wojciech
Note: See
TracTickets for help on using
tickets.
I will be very happy with the new names, as proposed here, since they have the scalar constants indicated in them, and the "divide by x" part. This makes checking of code and documentation much easier and less prone to errors or misunderstandings.
I suppose that Si(x) is sufficiently well known as sin(x)/x to stay as sas_Si
Richard