Opened 7 years ago

Closed 7 years ago

#696 closed defect (fixed)

Investigate core shell bicelle model

Reported by: richardh Owned by: butler
Priority: critical Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Looking at the c kernel code, I suspect that L in the model is actually the half length of the core, NOT the full length.

The equation in the description is not what is actually calculated.

I am not convinced yet that results are correct if sld of face is different to sld of rim.

The manual needs a diagram for the geometry of the bicelle. (The part with sld_face has radius Rcore)

Change History (7)

comment:1 Changed 7 years ago by richardh

The Length is OK (of course), as it got halved elsewhere.

comment:2 Changed 7 years ago by richardh

The limiting cases of:

(a) SLDface = SLDrim does generate a core/shell cylinder as expected.

(b) SLDcore=SLDface=SLDsolvent does generate a hollow cylinder (i.e. tube or pipe), as expected.

© SLDrim=SLDsolvent=SLDcore ought to generate two discs with a gap of L between them, I don't think this happens, suspect some horrible cross terms are missing.

comment:3 Changed 7 years ago by butler

regarding the graphic — the current graphic is taken from an RSC journal articles. While it is cited question is whether this constitutes "fair use" or would be a copyright infringement?

comment:4 Changed 7 years ago by richardh

Generated new graphics.

I(Q) equations look OK in code, need to check docs page now.

comment:5 Changed 7 years ago by richardh

  • Owner changed from richardh to butler
  • Status changed from new to assigned

Have generated two new images from scratch.

Edited equation in "description" box.

Starting parameters look a little odd? - hand over to Paul

comment:6 Changed 7 years ago by butler

In adc753dbe4450955415a1427496ad3341a93896e/sasmodels:

bicelle model documentation standardized, ref to original derivation and
equations added to rst documentation. re #696 and #646

comment:7 Changed 7 years ago by richardh

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.