Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#622 closed enhancement (obsolete)

Data2D stores no information about the shape/dimensionality of the data

Reported by: lewis Owned by:
Priority: major Milestone: SasView 4.0.0
Component: SasView Keywords:
Cc: Work Package: Plotting/Graphing Enhancements

Description

The Data2D object currently stores 2D data as three 1D arrays (data, qx_data and qy_data)

This is an issue when it comes to plotting the data, since the 1D data array needs to be converted into a 2D array, but the Data2D object has no information about what shape the 2D array should be.

It's also an issue when it comes to writing NXcanSAS files, since the data is written to the file as a 2D array.

Change History (6)

comment:1 Changed 13 months ago by lewis

The Data2D object does actually store information about the shape of the data in x_bins and y_bins, there was just a bug in cansas_reader_HDF5.py that x_bins and y_bins weren't being set.

However, there is still an issue that PlotPanel.py doesn't seem to know about these properties, so creates it's own bins based on the assumption that the data is square.

comment:2 Changed 13 months ago by smk78

Also, when we looked yesterday with Andrew, it wasn't clear that DataInfo? was being fed the size/shape.

comment:3 Changed 13 months ago by Lewis O'Driscoll <lewis.o'drisco

In [a4deca600c233c866bddf97395879f4fcd0758af]:

Set data.x_bins and data.y_bins in CanSAS 2.0 reader (references #622)

comment:4 Changed 13 months ago by lewis

Replying to smk78:

Also, when we looked yesterday with Andrew, it wasn't clear that DataInfo? was being fed the size/shape.

Data Info can figure out the shape of the data from the lengths of x_bins and y_bins, it just doesn't display this to the user

Last edited 13 months ago by lewis (previous) (diff)

comment:5 Changed 13 months ago by lewis

  • Resolution set to obsolete
  • Status changed from new to closed

Opened ticket #623 re: Steve's comment

comment:6 Changed 12 months ago by lewis

In ac370c578560050761b9b991a608df5a849588be/sasview:

Set data.x_bins and data.y_bins in CanSAS 2.0 reader (references #622)

Note: See TracTickets for help on using tickets.