Opened 6 years ago

Closed 6 years ago

#614 closed defect (fixed)

Loading Folder behavior oddity if folder contains non data file

Reported by: butler Owned by: lewis
Priority: major Milestone: SasView 4.0.0
Component: SasView Keywords:
Cc: Work Package: SasView Framework Enhancements


When loading and entire folder with Load Folder or in fact using load file and selecting all the files indiscriminately, The first non data file raises an error which could be a different kind of SasView file (a .svs file for example - and the helpful error tells you how to load it) or something not recognized at all (giving a different error message). The two issues however are:

  • The next non data file does not pop up an error.
  • Further all the GOOD files following that first non data file are listed in the pop up box even though they, along with all the valid data files are in fact loaded. This is very confusing to the user as it suggests that something is wrong with those files as well.

Attachments (3)

X27000.CF1 (98 bytes) - added by smk78 6 years ago.
OTOKO format header file (ASCII)
extract.txt (98 bytes) - added by smk78 6 years ago.
Corfunc parameter file (ASCII)
New Text Document.txt (6 bytes) - added by smk78 6 years ago.
Made up bogus data file (ASCII)

Download all attachments as: .zip

Change History (16)

comment:1 Changed 6 years ago by lewis

  • Owner set to lewis
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Lewis O'Driscoll <lewis.o'drisco

In [cba0c7737464448bab917b2585f4518e4428ed9a]:

Show more useful message when loading folder fails (closes #614)

comment:3 Changed 6 years ago by lewis

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 6 years ago by butler

  • Resolution fixed deleted
  • Status changed from closed to reopened

The fix now does allow all the non-loading data to be reported with an appropriate error message, not just the first one. However, build 436 on my windows machine now not only lists those files but also lists all the files that in fact do get loaded with the standard error message that they didn't get loaded attached to each. The pop up should lists all the non-loading data with appropriate messages but not list any of the files that do get loaded.

comment:5 Changed 6 years ago by Lewis O'Driscoll <lewis.o'drisco

In [70308f6c0db5fd4e37863a2fff66dd448c954d56]:

Fix error message shown when loading folder fails (fixes #614)

comment:6 Changed 6 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

There appears to be some rather convoluted logic going on. The latest fix does seem to stop the worst problem of having a popup indicating things had not loaded when in fact they did load.

However the behavior seems a bit erratic. Using some folders the pop up now works as intended, only listing files that failed to load and stating so an why. On the other hand using the test folder with some extra non data files thrown ins does not produce the pop up at all! It DOES however correctly identify in the console screen which files loaded and which failed to load and why. But even within the console screen there are some random behaviors where sometimes the errors are flagged in red preceded by a red x icon while in other cases the errors show up in normal black text preceded by the normal blue i (information) icon…. or sometimes no icon at all. Further ALL files show as loading — it seems that the error gets generated in a different stream and shows up sometime later in the list of information on the console - so loading x then at some random point later in the message stream … failed to load x.

Given that at least now the messages are correct and the fact that this may require some serious work, am moving it to the next release

comment:7 Changed 6 years ago by Lewis O'Driscoll <lewis.o'drisco

In [a674d0b7da37ed36693004d2d51e0941ed38842f]:

Re-write error handling code in data_loader (fixes #614)

comment:8 Changed 6 years ago by smk78

Also, if the folder contains any non-I(Q) data ASCII files that just happen to have space or tab delimited numbers in the opening lines then these get loaded as data (the first pair of numbers as X & Y). So examples of this include BSL/OTOKO 'header' files, eg: this CORFUNC file had the extension .CF1

     201       1       1       1       0       0       0       0       0       0

where it took the 201 & 1 as X & Y, or perhaps a temporary parameter file such as this one which had the extension .txt:

0.522096E+00  0.211909E-01  0.396440E-02  0.101775E-02  0.307366E-03

where it took the 0.522096E+00 0.211909E-01 as X & Y.

I suspect the ASCII reader is just a little too embracing. Maybe if it checked for two consecutive lines with pairs of numbers, or something like that? But tricky.

comment:9 Changed 6 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.0.0

This should actually not happen — ASCII reader has ALWAYS looked for X (where I think X is 6 now) rows with EXACTLY the same number of columns of numbers only. Not perfect but as close as one can get. Either there are more lines or a new bug has been introduced I think.

Can we have an example offending data file attached to this ticket?

comment:10 Changed 6 years ago by smk78

Just re-checked in ESS W7 Build 466, this ASCII issue still exists. Am appending three examples files: X27000.CF1, extract.txt & New Text Document.txt

Changed 6 years ago by smk78

OTOKO format header file (ASCII)

Changed 6 years ago by smk78

Corfunc parameter file (ASCII)

Changed 6 years ago by smk78

Made up bogus data file (ASCII)

comment:11 Changed 6 years ago by smk78

Uh-oh… Issue also exists in SasView 3.1.2!

Last edited 6 years ago by smk78 (previous) (diff)

comment:12 Changed 6 years ago by smk78

And SasView 2.2.1… so it's a very long-standing bug!

comment:13 Changed 6 years ago by butler

  • Resolution set to fixed
  • Status changed from reopened to closed

This is essentially fixed. The new behavior identified by Steve King is completely separate (a failure of the ASCII reader not the folder reader). I have taken the relevant information and attachments and created a new ticket for that with an appropriate title.

Note: See TracTickets for help on using tickets.