Opened 2 years ago

Closed 2 years ago

#581 closed defect (fixed)

min value on flat background should not be zero but -inf

Reported by: richardh Owned by: richardh
Priority: major Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Comparing 4.0 alpha2 fits with some user data in guinier_porod model, I noticed different results.
min value of flat background is set 0 instead of -inf, alas our neutron backgrounds can be negative if the model is cranky or users have oversubtracted incoherent etc.
I have not got build etc set up at present, perhaps someone else could fix this as this bug seems generic for all models.
Richard

Change History (7)

comment:1 Changed 2 years ago by butler

We need to resolve this… or move to +1 to resolve at code camp. A strong argument was made at a Tuesday discussion meeting that 0 is the correct min. Further it can be changed trivially by the user should they wish to do so. The strong part of the argument hinged on the mathematical incorrectness of the method and the fact that the resulting parameters and uncertainties would be completely wrong. This mathematical argument was made by Paul Kienzle but those in attendance tended to agree with his point. Unfortunately Richard Heenab was not present and the ticket was left open till further discussion could be had.

comment:2 Changed 2 years ago by butler

  • Priority changed from critical to major

comment:3 Changed 2 years ago by butler

  • Owner changed from richardh to ajj
  • Status changed from new to assigned

comment:4 Changed 2 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView 4.1.0

Richard out so will close loop after this release. moving to 4.1

comment:5 Changed 2 years ago by richardh

4th Oct 2016, discussion at code camp:
(a) Even if the "incoherent" or other background is "properly" subtracted, the fitted flat background may legitimately be negative, say -0.002 +- 0.01, thus we should not force background to always be positive.
(b) forcing positive background changes sasview to behave differently to how it used to, and to be different to any other fitting code.
© Users can then decide to fix flat background at a physically reasonable value.

Richard will change the default behaviour, see modelinfo.py around line 45

comment:6 Changed 2 years ago by richardh

  • Owner changed from ajj to richardh

comment:7 Changed 2 years ago by richardh

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.