Opened 4 years ago

Closed 4 years ago

#548 closed defect (fixed)

Remove MutiplicationModel.py once replacement from Sasmodels is available

Reported by: ajj Owned by: pkienzle
Priority: critical Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasModels Redesign

Description (last modified by butler)

Once we can replace MultiplicationModel with Product from sasmodels, we can remove MultiplicationModel.py

Change History (5)

comment:1 Changed 4 years ago by butler

  • Description modified (diff)
  • Owner set to pkienzle
  • Status changed from new to assigned

comment:2 Changed 4 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

Do not have bandwidth to deal with for 4.0 which is already mega late — can do at code camp or beyond. Leaving a high priority but moving to +1

comment:3 Changed 4 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.1.0

comment:4 Changed 4 years ago by pkienzle

sasmodels/product.py implements the product model as defined in SasView when a form factor is multiplied by a structure factor. This could be used directly from sasview.

Rather than using ProductKernel?, we could somehow make ER and VR into derived parameters that can be used in constraint expressions, and use constrained fitting to on a mixture model (sasmodels/mixture.py), with product rather than sum used to mix the models. This will be considerably more work, and belongs in a separate ticket.

comment:5 Changed 4 years ago by Paul Kienzle <pkienzle@…

  • Resolution set to fixed
  • Status changed from assigned to closed

In 313c5c92691602529afcffa8e76988a7cf6397b9/sasview:

use product model from sasmodels rather than sasview. Fixes #548, #760

Note: See TracTickets for help on using tickets.