Opened 9 years ago
Last modified 6 years ago
#542 new enhancement
capped_cylinder & barbell docs and/or computations could be improved
Reported by: | richardh | Owned by: | pkienzle |
---|---|---|---|
Priority: | minor | Milestone: | SasView 4.3.0 |
Component: | sasmodels | Keywords: | |
Cc: | Work Package: | SasView QA and testing |
Description
capped_cylinder computations could be improved - see notes included in the .py file, current model requires user to keep cap radius > cylinder radius
ticket submitted by Richard, but assigned to PAK, who may know what to do.
Change History (3)
comment:1 Changed 8 years ago by ajj
- Component changed from SansView to SasView
comment:2 Changed 6 years ago by richardh
- Component changed from SasView to sasmodels
- Milestone changed from SasView Next Release +1 to sasmodels WishList
- Summary changed from capped_cylinder computations could be improved to capped_cylinder & barbell docs and/or computations could be improved
comment:3 Changed 6 years ago by butler
- Milestone changed from sasmodels WishList to SasView 4.3.0
maybe this can be addressed in 4.3 along with paracrystalline models and validation of the be_polyelectrolyte
Note: See
TracTickets for help on using
tickets.
Whilst looking at ER calcs for barbell and capped_cylinder I note that there seems to be inconsistencies between the docs and the calculations. I suspect the calculation is OK but the docs need improvement?
e.g. concerning the sign of distance h, where for both models the docs say h is negative, but a note in capped_cylinder.c says it is positive.
e.g docs for both say "The scale factor is equivalent to the volume fraction of cylinders, each of volume, V" which is a little odd?
Suspect the orignal goal of this ticket to improve capped_cylinder calculations may have been done ? (need to look at github …)