Opened 4 years ago

Closed 4 years ago

#504 closed task (fixed)

Convert model editors to support sasmodels

Reported by: butler Owned by: gonzalezm
Priority: blocker Milestone: SasView 4.0.0
Component: SasView Keywords:
Cc: Work Package: SasModels Redesign

Description

Need to edit model_editor.py in sasview>src>sas>perspectives>calculator to accommodate new model structure. Mainly the composite model editor and the Easy model editor.

Read notes added in the file about suggested structural changes that might be appropriate at this time as well.

Change History (6)

comment:1 follow-up: Changed 4 years ago by piotr

Remember about other requirements, like http://trac.sasview.org/ticket/366

comment:2 in reply to: ↑ 1 Changed 4 years ago by butler

#366 regards allowing reparametrization of a model. It is interesting that the author of the ticket suggests an implementation similar to a custom model, as I've thought of this as a models infrastructure work. As an editor is not as intellectually satisfying and perhaps not as flexible a solution, but probably much more doable in the short term. Even so, as I understand it, this would have to be a 4th editor not an upgrade to an existing editor? (current model_editor.py has 3 classes as I recall, one is a window to pyshell, one is the sum models panel, and one is the custom model panel). One question however is what to do about c models. updating the python file output to be a sasmodel should be "easy" (meaning plenty of work but the tasks are clear). It might be nice to allow for adding the C bits?? but suspect that is a bridge too far for this release?

Replying to piotr:

Remember about other requirements, like http://trac.sasview.org/ticket/366

comment:3 Changed 4 years ago by ajj

Partially done. Easy sum/multi works.

Custom model editor does not yet.

comment:4 Changed 4 years ago by butler

  • Owner set to gonzalezm
  • Status changed from new to assigned

comment:5 Changed 4 years ago by gonzalezm

The custom model editor works and now creates a "sasmodel-type" python file that SasView can load and use. However the previous test to check that the model compiles and runs have not yet be reimplemented.

Last edited 4 years ago by butler (previous) (diff)

comment:6 Changed 4 years ago by butler

  • Resolution set to fixed
  • Status changed from assigned to closed

This was also done some time ago. However the sum model has been broken by numerous changes to sasmodels re-structuring but that is the subject of ticket #583.

Am thus closing this ticket now.

Note: See TracTickets for help on using tickets.