Opened 3 years ago

Closed 2 years ago

#493 closed enhancement (fixed)

Data Operations should allow for reasonable numerical fluctuations in q

Reported by: butler Owned by: mathieu
Priority: major Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Framework Enhancements

Description

Data Operations allows a user to perform simple arithmetic on two data sets (add, subtract, multiply, divide). At this time it does not however interpolate so that a check is made before performing a requested operation that the two data sets have exactly the same number of q points AND that each q point is EXACTLY the same. This is generally appropriate but will cause the operation to fail even if the q values are essentially identical but differ by even one in the last decimal place.

The attached 2D files provided by Jun-Li Lin of the University of Illionois are an example. These are large data sets presumably generated by a SAXS camera? Somehow the qx of 0.0755253 (either positive or negative) is so close to 0.07552525 that in the blank data set it evaluated to 0.0755252. This was the ONLY discrepancy yet the subtract operation fails as expected. this is roughly a difference of 1.5ppm and is clearly the same value. However in order to fix we will have to decide on a cutoff: how close is close enough? A more complicated but more satisfying answer would be to allow for an option that sets the maximum allowed jiggle.

Another option that might be interesting is to allow interpolation. interpolation

Attachments (2)

25883_Iqxy.dat (6.4 MB) - added by butler 3 years ago.
25884_Iqxy.dat (6.3 MB) - added by butler 3 years ago.

Change History (6)

Changed 3 years ago by butler

Changed 3 years ago by butler

comment:1 Changed 2 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

another enhancement that would not be too difficult and very nice to have but given the resources available and amount of work to do for release 4.0 sadly need to move to +1

comment:2 Changed 2 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.1.0

comment:3 Changed 2 years ago by mathieu

  • Owner set to mathieu
  • Status changed from new to accepted

comment:4 Changed 2 years ago by mathieu

  • Resolution set to fixed
  • Status changed from accepted to closed

In 1b1a1c1f5fa5d17a2e503d0e1803259f57dc943a/sasview:

Add tolerance to data ops. Fixes #493

Note: See TracTickets for help on using tickets.