Opened 5 years ago

Closed 3 years ago

#489 closed defect (fixed)

ABS reader (NIST 1D) does not handle negative dx properly (USANS slit smearing)

Reported by: pkienzle Owned by: krzywon
Priority: critical Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description (last modified by butler)

The NIST (*.ABS) USANS files contain the slit length as a negative entry in the dx column which is not recognized by the reader. Need to add the case of dx < 0 then dx =NONE and dl = abs(dx).

Attachments (1)

sam14_cor (9.4 KB) - added by pkienzle 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by pkienzle

comment:1 Changed 5 years ago by butler

  • Description modified (diff)
  • Milestone changed from SasView Next Release +1 to SasView 4.0.0
  • Summary changed from new reader for NIST Igor USANS format to ABS reader (NIST 1D) does not handle negative dx properly (USANS slit smearing)

comment:2 Changed 4 years ago by butler

  • Owner set to krzywon
  • Priority changed from minor to critical
  • Status changed from new to assigned

This is important to the NIST community so we would like to fix it in this release. Should only impact NIST 1D data (.ABS) so should not be any need for general infrastructure questions discussion making it fairly clean and easy?

comment:3 Changed 4 years ago by krzywon

I took a quick look and noticed the USANS data, because it has no data file extension, is getting loaded by the generic ASCII reader. This will take a small infrastructure change and updates to the ABS reader to get working.

comment:4 Changed 4 years ago by butler

I don't think we should be encouraging changes to general readers to support individual idiosyncrasies. Ultimately we can dilute our efforts significantly if we try to support all data formats and their idiosyncrasies anyway (that is why I thought we supported standard formats), but those that we do have should be confined to their own reader?

NIST folk should be using NIST or standard formats I would think?

comment:5 Changed 4 years ago by butler

  • Priority changed from critical to minor

comment:6 Changed 4 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

As agreed on fortnightly call of June 21, am moving all minor priority tickets to next release (+1) given the resources and time available to get this release out.

comment:7 Changed 3 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.2.0
  • Priority changed from minor to critical

The regular ASCII reader should not be changed to deal with a NIST idiosyncrasy. However the .ABS reader, as a NIST reader, and as the ticket title implies should in fact respect the NIST format. A test with 4.1.2 shows the reader sees the negative fourth column as a pinhole resolution with a negative dq. Given the cleanup of the readers the ABS reader should be fixed for the next release.

comment:8 Changed 3 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 2b442811f6c17cdc297505d0d4fe58dcfa5111fc/sasview:

Merge pull request #134 from SasView?/ticket-489

Ticket 489: Properly handle negative dx values in the ABS reader.

closes #489

Note: See TracTickets for help on using tickets.