Opened 5 years ago

Closed 5 years ago

#486 closed defect (fixed)

Report Results broken in Jenkins build of 3.1.1

Reported by: smk78 Owned by: butler
Priority: blocker Milestone: SasView 3.1.2
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Windows 7.
Spotted by Richard, verified by Steve.

Report Results is broken in the Jenkins build of 3.1.1. Works in the release version of 3.1.1 and 3.0.0.

We initially thought it was a feature of the recent forced update of Adobe Acrobat Reader from X to DC, but DC works with the earlier versions.

Change History (3)

comment:1 Changed 5 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 3.2.2

Seems like this should be fixed before we release 3.1.2 if it was working in 3.1.1? Should probalby check on local builds first to see if a Jenkins build problem or a problem introduced by wxID fixes for example.

comment:2 Changed 5 years ago by butler

  • Owner set to butler
  • Status changed from new to accepted

Looks like problem was from wxID cleanup where all -1 were replaced with a wx.ID_ANY which is much better for searching later but requires an import wx statement which one of the files, pagestate, did not have. Checking all other files changed to make sure that was the only such instances.

comment:3 Changed 5 years ago by paul butler <butlerpd@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In [abcbe097d74401f06e04d41c9fe6612fd97f6dad]:

added import wx statement to pagestate.py to fix error introduced by
replacing -1 with wx.ID_ANY as the ID for the report results panel. All
other files touched were checked for the import statement as well.
Fixes #486

Note: See TracTickets for help on using tickets.