Opened 6 years ago

Closed 6 years ago

#442 closed defect (fixed)

Saving plot to file doesn't work from context menu

Reported by: butler Owned by: butler
Priority: major Milestone: SasView 3.1.0
Component: SasView Keywords: plot, matplotlib
Cc: Work Package: SasView Bug Fixing

Description

As reported by Steve King during v. 3.1.0 release testing the toolbar save icon works correctly but the context menu save does not.

Change History (2)

comment:1 Changed 6 years ago by butler

Matplot lib got us again!!! saving is no longer toolbar.save but toolbar.save_figure. I have fixed locally. will push one I finish fixing the printing issue (or later tonight whichever comes first).

comment:2 Changed 6 years ago by butler

  • Resolution set to fixed
  • Status changed from new to closed

Have fixed as per above. the toolbar worked because save is a part of the default toolbar provided by Matplotlib and hence handled directly by it. The pop up menu had to make the call directly and was now wrong.

Fix works on both mac and PC from instalable.
Something that may need more testing (and a possible ticket) is that it seems many formats are possible to save to (looks like coming from host environment?). Tried a couple which worked but then jpeg save poped up an error on mac that it was not supported. (jpeg worked on pc). As I say - needs more testing and if appropriate a new ticket.

Note: See TracTickets for help on using tickets.