Opened 2 years ago

Closed 18 months ago

#439 closed defect (fixed)

Hayter Penfold MSA code needs checking

Reported by: butler Owned by: richardh
Priority: blocker Milestone: SasView 4.0.0
Component: SasView Keywords:
Cc: Work Package: SasView QA and testing

Description

Richard Heenan thinks that the HMSA structure factor may be giving different answer to FISH version. They have the same origin so should be the same. This still nees furhter checking and if a real problem will then need to be addressed

Change History (6)

comment:1 Changed 2 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.0.0

comment:2 Changed 21 months ago by butler

  • Work Package changed from SasView Bug Fixing to SasView QA and testing

comment:3 Changed 19 months ago by ajj

  • Priority changed from major to blocker

comment:4 Changed 19 months ago by butler

  • Status changed from new to assigned

comment:5 in reply to: ↑ description Changed 19 months ago by richardh

Replying to butler:

Richard Heenan thinks the HP S(Q) is likely OK (it is not necessarily identical to what is in FISH)

New version, with Taylor expansion at small Q, needs sorting out at code camp, has not been uploaded to GIT as I want to replace present one (which has a bug) with a version having a more sensible name.

comment:6 Changed 18 months ago by butler

  • Resolution set to fixed
  • Status changed from assigned to closed

This is as finished as it will be. Main conclusion is it will have to ALWAYS use double precision. May add a FISH version later which may be more stable. However this code looks correct. Closing this ticket.

Note: See TracTickets for help on using tickets.