Opened 9 years ago
Closed 9 years ago
#433 closed defect (fixed)
Check for updates does not work on GitHub yet
Reported by: | butler | Owned by: | butler |
---|---|---|---|
Priority: | major | Milestone: | SasView 3.1.0 |
Component: | SasView | Keywords: | |
Cc: | Work Package: | SasView Bug Fixing |
Description
The "check for updates" functionality was pointing at sourceforge. It now points to the GitHub? release repo but the script that does the work needs to be fixed.
Also, for those with any prior release how do we set sourceforge to tell them that there is a new version?
Change History (6)
comment:1 Changed 9 years ago by butler
- Owner set to butler
- Status changed from new to assigned
comment:2 Changed 9 years ago by butler
comment:3 Changed 9 years ago by butler
The code we want to use is:
import urllib2 req = urllib2.Request('https://github.com/SasView/sasview/releases/latest') res = urllib2.urlopen(req) print res.geturl()
which currently returns (prints)
https://github.com/SasView/sasview/releases/tag/v3.0.0
then just return everthing after tag/v. Is this where re package would be useful?
comment:4 Changed 9 years ago by trnielsen
New check_update in gui_mamager.py has been pushed to Github. The new method is implemented as suggested in Ticket #443. And the set_up_exe.py has been changed so that the module ‘_ssl’ in now included. Works on the ESS Win7 build server and on my local bare OSX and Win7 VMs.
comment:5 Changed 9 years ago by smk78
Known Issues section of 3.1.0 Release Notes updated.
Website faq.html also updated with instructions for Win 7 users and committed to repo. NB: But this is not currently being pushed to the server at UTK for some reason .
comment:6 Changed 9 years ago by smk78
- Resolution set to fixed
- Status changed from assigned to closed
Changes now pushed to repo.
Think we can close this ticket now!
check for updates now works as before on sourceforge. However it relies on setting the verion in master/sasview.latestversion simultaneously with the official release. On GitHub? we can use
which will re-evaluate to:
where x.x.x is the latest taged release. We should be using this instead. But this may be for the next release?