Opened 10 years ago
Closed 10 years ago
#405 closed defect (fixed)
resolution is being cleared when fit starts
| Reported by: | pkienzle | Owned by: | pkienzle |
|---|---|---|---|
| Priority: | critical | Milestone: | SasView 3.1.0 |
| Component: | SasView | Keywords: | |
| Cc: | Work Package: | SasView Bug Fixing |
Description
With a 1-D dataset and instrumental smearing set to Use dQ Data, clicking Fit resets instrumental smearing to None.
Change History (5)
comment:1 Changed 10 years ago by butler
comment:2 Changed 10 years ago by butler
- Milestone changed from SasView Next Release +1 to SasView 3.1
- Priority changed from major to critical
comment:3 Changed 10 years ago by butler
- Owner set to pkienzle
- Status changed from new to assigned
comment:4 Changed 10 years ago by pkienzle
The fitting perspective needs to be refactored into proper MVC. As it stands, when the fit button is clicked the program goes through the fields on the page and pulls out various values such as the smearing to use. Instead, the fit description should be an independent object which is updated by the GUI whenever anything on the page changes. This should remove the problem which seems to be that the page is redrawn when the fit button is pressed, and the wrong fit description is sometimes captured.
This large of a change should not be done for 3.1, but I've made no progress on discovering exactly where the page refresh occurs that is causing the bug.
comment:5 Changed 10 years ago by pkienzle
- Resolution set to fixed
- Status changed from assigned to closed
For reasons unknown, disabling the Fit button caused the disable_smearer button to fire. A bug in wx?
I have verified that it is NOT a problem with version 3.1 alpha from just before code camp. It is still a problem on latest (April 6, 2015) jenkins windows build. It is however NOT a problem on the MAC. On windows the whole bottom half of the sizer (from smearing to fit) erase and get redrawn … it seems twice?)