Crashing mostly on Exit

[butler]

The last several builds have been crashing, mostly on exit but not always with the following error popup with title of Microsoft Visual C++ Runtime Library

               Microsoft Visual C++ Runtime Library

Runtime Error!

Program: C:\Program Files (x86)\SasView\SasView.exe

R6025
- pure virtual function call

One has to click OK and it pops up again and again. Eventually clicking Ok a popup indicates SasView has crashed. No information is added to the log that can help debug more.

NOTE: this has been verified using windows installer version downloaded from ESS Jenkins builds.

[krzywon]

This is related to opening and closing (plot only?) windows. If you open multiple plot windows and close a few (but not all of them), the error is generated on closing. If you open multiple, but do not close any, no error is thrown. If you open multiple and close them all, no error occurs. This suggests the windows aren't completely destroyed on closing until all plots are closed. When the main program closes, it tries to close all known windows, but if they are already closed, they cannot be found, throwing the error.

[pkienzle]

More details:

You don't need to delete the graph; you just need the graph to not have focus.

The crash happens during exit processing, specifically wx._core_.App_Cleanup.

For some reason, the App_CleanUp is triggering PlotPanel?.on_set_focus. I was unable to determine why this was happening, and couldn't remove it.

Instead, I traced the crash to data_panel.set_panel_on_focus, which updates the "Append Plot" dropdown with the list of active panels, and sets the string to the active panel.

The "fix" (aka ugly hack) is to modify the function to check if the "Append Plot" dropdown widget is being deleted before updating the widget.